Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actualize swap statuses JSON structure #757

Closed
tonymorony opened this issue Dec 3, 2020 · 2 comments
Closed

Actualize swap statuses JSON structure #757

tonymorony opened this issue Dec 3, 2020 · 2 comments
Assignees

Comments

@tonymorony
Copy link

tonymorony commented Dec 3, 2020

Structure of some events is not actual (at least for payments).

E.g.:

but actually it's inside of "transaction" key now

e.g.

{"type":"TakerPaymentSpent","data":{"transaction":{"tx_hex":"0400008085202f8901afc73c5105a82cbb226d1513686645c46a21819ef9a51f651519a2a37cb8735800000000d8483045022100b057313035830269a46f66862e6eaefb83f533c3cd61d2129a1780167d60b4b6022026d083cdea6d208f38f7dc4dc5e43198d48e28761f1f97c6f55fdb4c2bc1496f0120e6a08688b2e7dd45ae700a3d1344af87fd471163ebb04ef54bd61d1bb60938e6004c6b63041b40c65fb1752103aa464529c190398d44017c3d7a71a854ad195a9d396bf84182679c242bb60085ac6782012088a914d7bd49f4f9f56547e58126435b6a0ed9b56cf56d882103e82ce803f835fb1101004f7b8993513f1062727e7bc2228e4b030f4a39b32b56ac68ffffffff0118ddf505000000001976a914bd383d0da3e374c49e173a4b7a354a53e596101088ac3d14c65f000000000000000000000000000000","tx_hash":"f94e91b18e280d10c832a1656a277f4111d938fa1a598d335cbc5c16f541a9c2"}

thanks to @yurii-khi for reporting!

@artemii235 artemii235 self-assigned this Dec 3, 2020
@artemii235
Copy link
Member

Thanks for reporting this! Yeah, from taker side the TakerPaymentSpent event has separate transaction field for tx data so docs should be updated.

@artemii235
Copy link
Member

Fixed, docs PR: KomodoPlatform/developer-docs#235

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants