Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: wrap amount in the coin transaction history #1844

Closed
Canialon opened this issue Jul 3, 2022 · 6 comments · Fixed by #1883
Closed

[BUG]: wrap amount in the coin transaction history #1844

Canialon opened this issue Jul 3, 2022 · 6 comments · Fixed by #1883
Labels
bug Something isn't working Front-end next iteration to not forget to include it P2 Time permissive

Comments

@Canialon
Copy link

Canialon commented Jul 3, 2022

the context of a transaction in the coin transactions list is not center-aligned if the amount takes two lines.

UPD:
should remove text wrap if the string is too long for a single line

image

@Canialon Canialon added the bug Something isn't working label Jul 3, 2022
@cipig
Copy link
Member

cipig commented Jul 3, 2022

can we make sure it's always only one line?

@Canialon
Copy link
Author

Canialon commented Jul 3, 2022

can we make sure it's always only one line?

alignment with amount in one line:
image

alignment with wrap amount :
image
I meant the horizontal alignment

@ghost
Copy link

ghost commented Jul 4, 2022

I meant the horizontal alignment

You meant vertical alignment right ? @Canialon

@smk762 smk762 added Front-end P2 Time permissive next iteration to not forget to include it labels Jul 4, 2022
@Canialon
Copy link
Author

Canialon commented Jul 4, 2022

You meant vertical alignment right ? @Canialon

horizontal

image

@cipig
Copy link
Member

cipig commented Jul 4, 2022

You meant vertical alignment right ? @Canialon

horizontal

image

that's what i meant... if the string "DOGE-BEP20 200" would be one line and not two, the problem wouldn't exist. if the string is too long for single line on certain resolutions, remove "DOGE-BEP20" from the string and keep only the value... it's clear anyway that it's DOGE-BEP20 because you are looking at DOGE-BEP20 wallet

@Canialon Canialon changed the title [BUG]: not center-aligned context if the amount takes two lines [BUG]: wrap amount in the coin transaction history Jul 4, 2022
@Canialon
Copy link
Author

Canialon commented Jul 4, 2022

that's what i meant... if the string "DOGE-BEP20 200" would be one line and not two, the problem wouldn't exist. if the string is too long for single line on certain resolutions, remove "DOGE-BEP20" from the string and keep only the value... it's clear anyway that it's DOGE-BEP20 because you are looking at DOGE-BEP20 wallet

got it now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Front-end next iteration to not forget to include it P2 Time permissive
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants