Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

Use "kong" or get service name from env variable or config. #23

Closed
longit644 opened this issue Oct 9, 2018 · 3 comments · Fixed by #45
Closed

Use "kong" or get service name from env variable or config. #23

longit644 opened this issue Oct 9, 2018 · 3 comments · Fixed by #45

Comments

@longit644
Copy link
Contributor

longit644 commented Oct 9, 2018

When I use Kong Zipkin plugins, the list of services in tracer dashboard is polluted with many services.

I think, we should to get service name from env variable (ex: KONG_ZIPKIN_PLUGIN_SERVICE_NAME), or add to config or just "kong".

@james-callahan
Copy link
Contributor

When I use Kong Zipkin plugins, the list of services in tracer dashboard is polluted with many services.

Doesn't it end up being the same as the number of services that you have in Kong?
Why is this a problem? Wouldn't you want to drill down into per-service latencies?

just "kong" at here

We already set "kong" as the 'component'.

@longit644
Copy link
Contributor Author

longit644 commented Oct 9, 2018

Doesn't it end up being the same as the number of services that you have in Kong?

If I use the same service name for spans in Kong service and in my service, it's difficult to get how many spans in Kong, how many spans in my service and their latency.
If I use a service name for spans in Kong service and another in my service, there are many services appearing in the list of services in tracer dashboard, so it's difficult to manage them.

Wouldn't you want to drill down into per-service latencies?

No no, I really want it. But I want more details.

@secat
Copy link

secat commented Jul 22, 2019

@james-callahan any update on this feature request?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants