Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Kotlin @Deprecated annotation #185

Closed
alshan opened this issue Apr 6, 2021 · 2 comments
Closed

Add support for Kotlin @Deprecated annotation #185

alshan opened this issue Apr 6, 2021 · 2 comments

Comments

@alshan
Copy link
Contributor

alshan commented Apr 6, 2021

I deprecated symbol "lets_plot" in favor of "letsPlot":

@Deprecated("", ReplaceWith("letsPlot(data, mapping)"))
fun lets_plot(data: Map<*, *>? = null, mapping: GenericAesMapping.() -> Unit = {}) = letsPlot(data, mapping)

In IDEA user can see the deprecated symbol and can choose to auto-fix:

image


In Jupyter notebook user can not tell a deprecated symbol from the new one (and most likely there is no auto-fix provided):

image

@ileasile
Copy link
Contributor

ileasile commented May 3, 2021

There is really no autofix and crossed completion variants, but there should be warnings:
image

Do you have them?

@alshan
Copy link
Contributor Author

alshan commented May 4, 2021

See them but not always - see screenshot for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants