Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move loading out of preprocessing #322

Closed
juliabeliaeva opened this issue Jan 5, 2022 · 0 comments · Fixed by #323
Closed

Move loading out of preprocessing #322

juliabeliaeva opened this issue Jan 5, 2022 · 0 comments · Fixed by #323
Milestone

Comments

@juliabeliaeva
Copy link
Contributor

It seems that loading functionality should be moved out of preprocessing to the Dataset implementations.

  1. Loading images is orthogonal to preprocessing. Having a loading stage limits preprocessors functionality, as it prohibits sharing preprocessors between datasets or applying them to images loaded from elsewhere.
  2. Knowledge about the source of the images is intrinsic to some of the Dataset implementations, specifically OnFlyImageDataset.
  3. The code creating dataset implementations already directly accesses loading stage of the provided Preprocessing instance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant