Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor OnnxInferenceModel to reduce code duplication #358

Closed
ermolenkodev opened this issue Apr 20, 2022 · 1 comment · Fixed by #465
Closed

Refactor OnnxInferenceModel to reduce code duplication #358

ermolenkodev opened this issue Apr 20, 2022 · 1 comment · Fixed by #465
Assignees
Milestone

Comments

@ermolenkodev
Copy link
Collaborator

I think it would be a good idea to unify this (predictSoftly) method with predictRaw (as a separate PR).

Originally posted by @juliabeliaeva in #356 (comment)

@zaleslaw
Copy link
Collaborator

Keep in mind the predictSoftly method for the TensorFlow models before refactoring

The initial idea of the predictSoftly method is the following: return the vector of probabilities instead of the class label calculated via argmax on the vector of probabilities.

The semantic for the predictRaw is more common – to return just low-level output with a few tensors, for example, not just 1D vector

@zaleslaw zaleslaw added this to the 0.5 milestone May 20, 2022
@ermolenkodev ermolenkodev removed this from the 0.5 milestone Sep 21, 2022
@juliabeliaeva juliabeliaeva self-assigned this Oct 6, 2022
@juliabeliaeva juliabeliaeva added this to the 0.5 milestone Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants