Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline installation is not possible to due build script #215

Closed
theCapypara opened this issue Jun 9, 2023 · 2 comments · Fixed by #216
Closed

Offline installation is not possible to due build script #215

theCapypara opened this issue Jun 9, 2023 · 2 comments · Fixed by #216

Comments

@theCapypara
Copy link

The build script added a pip install command. This breaks offline installation and also ignores any other setting passed to any parent pip command that was installing cairocffi in the first place.

subprocess.run([str(pip), 'install', 'xcffib'])

The reason it breaks is because even though the exception is caught, an Exception during the installation there means that cffi is not installed and then the exec_module a few lines later fails, causing the entire build to fail.

cairocffi should really not call pip inside of it's build script.

@nanonyme
Copy link

nanonyme commented Jun 9, 2023

It sounds to me this is incorrect definition of build dependencies. This project should be declaring xcffib in

requires = ["setuptools >= 61.0.0", "cffi >= 1.1.0"]
rather than installing it manually with pip

@liZe
Copy link
Member

liZe commented Jun 10, 2023

This will be fixed by the in-line branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants