Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_GetScheme to avoid duplicated code #4390

Closed
miguelmaso opened this issue Mar 8, 2019 · 3 comments · Fixed by #6575
Closed

_GetScheme to avoid duplicated code #4390

miguelmaso opened this issue Mar 8, 2019 · 3 comments · Fixed by #6575
Assignees
@jcotela
Milestone
Release 8.0

Comments

@miguelmaso
Copy link
Contributor

In PR #3714 the PFEM2NavierStokesMonolithicSolver that derives from NavierStokesMonolithicSolver there is some copied code. An implementation of _GetScheme and _GetBuilderAndSolver methods in the base class would reduce that necessary code duplication.
I suggest to discuss that on this issue to unblock the PR #3714
@philbucher
Copy link
Member

I think this is coming in the next wave of refactoring of the fluid-solvers, at least @jcotela told me this

@miguelmaso
Copy link
Contributor Author

thanks. In that case, can we close that issue?

@philbucher philbucher mentioned this issue Mar 8, 2019
Closed
4 tasks
@philbucher
Copy link
Member

closing, added it to the list

@philbucher philbucher mentioned this issue Mar 2, 2020
Merged
@philbucher philbucher reopened this Mar 6, 2020
@philbucher philbucher added this to the Release 8.0 milestone Mar 6, 2020
@rubenzorrilla rubenzorrilla mentioned this issue Mar 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcotela jcotela

Labels
None yet
Projects
None yet
Milestone
Release 8.0
Development

Successfully merging a pull request may close this issue.

[Fluid] Fine grained Python solvers KratosMultiphysics/Kratos
3 participants
@jcotela @philbucher @miguelmaso