Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 limit::conditions and have Conditions be proper CEL Predicates #385

Closed
5 of 6 tasks
alexsnaps opened this issue Nov 14, 2024 · 0 comments · Fixed by #396
Closed
5 of 6 tasks

🔥 limit::conditions and have Conditions be proper CEL Predicates #385

alexsnaps opened this issue Nov 14, 2024 · 0 comments · Fixed by #396
Assignees

Comments

@alexsnaps
Copy link
Member

alexsnaps commented Nov 14, 2024

So to leverage CEL consistently across all Kuadrant components

  • Parse Limit's conditions as CEL expression (on creation)
  • Parse Limit's variables as CEL expression (again, on creation)
  • 🔥 feature lenient_conditions
  • 🔥 module crate::limit::conditions
  • Inject context about the Limit itself in the interpreter to enable e.g. Limit::id lookup (one context for the whole Limit, i.e. all conditions and all variables being resolved)
  • Should the descriptor(s) and their entries be first class citizens and have their own root binding?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant