Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Media server crashes when calling proccessOffer with an empty string using the node library #12

Closed
kapetan opened this issue Nov 13, 2015 · 4 comments
Labels
bug Non-critical bug affecting expected behavior kms Related especifically to the media server

Comments

@kapetan
Copy link

kapetan commented Nov 13, 2015

We are using kurento-client version 6.1.0 module in Node.js.

When calling WebRtcEndpoint.processOffer('') with an empty string the the media server crashes. The error log contains following entry.

** (kurento-media-server:21255): CRITICAL **: kms_ref_struct_ref: assertion 'refstruct != NULL' failed

The same error occurs when calling processAnswer with an empty string. It can also be reproduced by using a RtpEndpoint.

We're running Ubuntu 14.04 LTS and the following Kurento version.

Version: 6.1.1
Found modules:
    Module: 'core' version '6.1.2'
    Module: 'elements' version '6.1.1'
    Module: 'filters' version '6.1.1'
@igracia igracia added bug Non-critical bug affecting expected behavior kms Related especifically to the media server labels Nov 13, 2015
@igracia
Copy link
Contributor

igracia commented Nov 13, 2015

Thanks for the report and for spotting that out, Mirza. We'll certainly have a look at this.

@jcaden Could you have a look at this, please? It seems that the WebRtcEndpoint.processOffer() chokes on empty string params, and wreaks havoc in the KMS.

@jcaden
Copy link
Member

jcaden commented Nov 13, 2015

I think that I fixed this in the development version a couple of weeks ago. Could you please try with dev version to confirm that it is fixed?

@kapetan
Copy link
Author

kapetan commented Nov 13, 2015

It's seems to have been fixed.

I tried it with development version:

Version: 6.1.2~4.g3c371d0
Found modules:
    Module: 'core' version '6.1.3~41.g3d7be7b'
    Module: 'elements' version '6.1.2~35.gc88c519'
    Module: 'filters' version '6.1.2~3.gf1efe25'

And got an Empty offer not valid error back.

Thanks for the quick reply.

@igracia
Copy link
Contributor

igracia commented Nov 13, 2015

Ok, I'm closing this issue then. Next time, please make sure to check first with the development version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Non-critical bug affecting expected behavior kms Related especifically to the media server
Projects
None yet
Development

No branches or pull requests

3 participants