Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for worker prompt truncation in ChatML case #3673

Merged
merged 6 commits into from
Aug 29, 2023
Merged

Fixes for worker prompt truncation in ChatML case #3673

merged 6 commits into from
Aug 29, 2023

Conversation

olliestanley
Copy link
Collaborator

No description provided.

@olliestanley olliestanley changed the title Fixes for ChatML support workers Fixes for worker prompt truncation in ChatML case Aug 29, 2023
@olliestanley olliestanley marked this pull request as ready for review August 29, 2023 16:58
andreaskoepf
andreaskoepf approved these changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@andreaskoepf andreaskoepf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks a lot!

@andreaskoepf andreaskoepf merged commit adcf8dc into main Aug 29, 2023
@andreaskoepf andreaskoepf deleted the inference-chatml-fixes branch August 29, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaskoepf andreaskoepf andreaskoepf approved these changes

@melvinebenezer melvinebenezer Awaiting requested review from melvinebenezer melvinebenezer is a code owner

@yk yk Awaiting requested review from yk yk is a code owner

@AbdBarho AbdBarho Awaiting requested review from AbdBarho AbdBarho is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olliestanley @andreaskoepf