Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unifying dndz objects to avoid code duplication #320

Closed
vitenti opened this issue Oct 6, 2023 · 0 comments · Fixed by #321
Closed

Unifying dndz objects to avoid code duplication #320

vitenti opened this issue Oct 6, 2023 · 0 comments · Fixed by #321
Assignees
@vitenti

Comments

@vitenti
Copy link
Collaborator

vitenti commented Oct 6, 2023

Currently pylint is failing due to code duplication in number_counts.py and weak_lensing.py, the code in question is the dndz description related to each source. We should move this code to a single model.
@vitenti vitenti self-assigned this Oct 6, 2023
@vitenti vitenti linked a pull request Oct 8, 2023 that will close this issue
Creating a base class for galaxy based sources. #321
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vitenti vitenti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Creating a base class for galaxy based sources. LSSTDESC/firecrown
1 participant
@vitenti