Update template for UI #84
Conversation
templates/ui-package/package.json
Outdated
| }, | ||
| "devDependencies": { | ||
| "@angular/compiler": "6.0.4", |
There was a problem hiding this comment.
@rafaelcalpena Can you unpin the @angular dependencies by adding a carat please? e.g. "^6.0.4"
templates/ui-package/package.json
Outdated
| "@storybook/addons": "3.4.6", | ||
| "@storybook/angular": "3.4.6", | ||
| "@types/jasmine": "^2.5.54", | ||
| "coveralls": "^3.0.1", |
There was a problem hiding this comment.
@rafaelcalpena You can remove coveralls, since we switched to CodeCov
templates/ui-package/package.json
Outdated
| "@commitlint/cli": "^6.2.0", | ||
| "@commitlint/config-conventional": "^6.1.3", | ||
| "@labshare/semantic-release-config": "^1.0.0", | ||
| "@storybook/addon-actions": "3.4.6", |
There was a problem hiding this comment.
@rafaelcalpena Since storybook has not been incorporated in the workflow, we can omit it for now.
| @@ -0,0 +1,58 @@ | |||
| /* Obtained from https://github.com/LabShare/ng-qhts/blob/master/test/main-index.ts */ | |||
There was a problem hiding this comment.
@rafaelcalpena Comment can be removed
templates/ui-package/tslint.json
Outdated
| @@ -0,0 +1,138 @@ | |||
| { | |||
| "rulesDirectory": [ | |||
| "node_modules/codelyzer" | |||
There was a problem hiding this comment.
@rafaelcalpena Please switch this to the tslint angular check instead.
| 'test/main-index.ts', | ||
| // Include Angular Material 2 theme to address: | ||
| // https://github.com/angular/material2/issues/4056 | ||
| 'node_modules/@angular/material/prebuilt-themes/indigo-pink.css' |
There was a problem hiding this comment.
@rafaelcalpena We can omit @angular/material for now?
templates/ui-package/package.json
Outdated
| "packageDependencies": { | ||
| "@labshare/shell": "*" | ||
| }, | ||
| "dependencies": { | ||
| "@labshare/shell": "https://github.com/LabShare/shell", | ||
| "lodash": "^4.6.1" | ||
| "@labshare/shell": "^3.0.8", |
There was a problem hiding this comment.
@rafaelcalpena @labshare/shell should be a devDependency now after the latest changes.
# [2.2.0](v2.1.0...v2.2.0) (2018-07-19) ### Bug Fixes * add app.ts to main package json property ([0510459](0510459)) * add winston-transport to dependencies ([0ce97ea](0ce97ea)) * SHELL-1316 #done add commitlint config to ui-template ([c89f167](c89f167)) ### Features * update template for UI packages SHELL-1316 ([#84](#84)) ([66b22fd](66b22fd))
No description provided.