-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No longer working on Chome 34.0.1847.76 #124
Comments
Hi, could you review #108 please? I think it relates to what you experience. |
I think #108 is related but different. Examining the TCP stream I see this for Chrome:
Firefox's is almost identical:
The error is being produced by this file in Chrome: https://chromium.googlesource.com/chromium/src/net/+/master/websockets/websocket_basic_handshake_stream.cc I'm not sure I'm quite following the logic in that source file, but shouldn't the reply contain a Sec-WebSocket-Protocol header to tell the client which subprotocol the server's decided to use? |
Yes. But what did you initialize the server handler with? Did you pass any subprotocols? |
I wasn't aware I could --- I can't find anything in the docs about subprotocols. I'm using the gevent backend, and my code is:
How would I pass in a list of subprotocols? |
The doc isn't always good I admit. server = WSGIServer(
('0.0.0.0', args.port),
WebSocketWSGIApplication(protocols=['chat'], handler_cls=Connection)
) |
Using a subprotocol of 'binary' makes everything work. Thanks! |
Sweet. I will try to update the doc soon on this issue. |
After updating my app (which I haven't touched for a while) to work with the new APIs, I now find that while it still works fine on Firefox, trying to connect via Chrome 34 produces a 'Error during WebSocket handshake: Sent non-empty 'Sec-WebSocket-Protocol' header but no response was received' message.
This is with ws4py 0.3.2-1 from Debian.
I have an instance of my app running --- I'll try to keep it going for a while. When it loads, you'll get a login page if everything's working or a 'Disconnected from server' if it's not.
http://cowlark.com/~dg/thickishstring
The source is browsable here:
https://cowlark.com/thickishstring/artifact/80406f2ca2a7c2ecebfd00ead64bf074b8b9c746
The text was updated successfully, but these errors were encountered: