Server not handling "Upgrade" header case-insensitively, as it should

[ysangkok]

According to the standard draft 10 that the README says this server conforms to, the Upgrade header should be handled case-insensitively. Currently it is handled case-sensitively.

middleware.py:

def __call__(self, environ, start_response):
    # Initial handshake validation
    try:
        if 'websocket' not in environ.get('upgrade.protocol', ''):
            raise HandshakeError("Upgrade protocol is not websocket")

[ysangkok]

The problem is still there, in cherrypyserver.py:125. I can't reopen. Should I make a new issue?

[Lawouach]

Have you tried? IIRC CherryPy header's dict is case insensitive so it doesn't need to be explicitly transformed.

[ysangkok]

Yes, I tried. The reason I didn't catch it earlier is that I modified the client library. Now that I'm running with the original client library (AutobahnAndroid), the problem appears. I'm pretty sure the case-insensitivity only applies to the keys. If it didn't, base64 would break.

[Lawouach]

Right. I think I went too fast this morning. You're quite right and i'll be looking at it as soon as I get a new computer to replace my dead one :p

[ysangkok]

I'm in no rush, but did you get that new computer yet?

[Lawouach]

Hopefully this should be taken care of now. I need to find an easy way to unit tests the tool properly.