-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ws4py shouldn't send a masked message to the client #50
Comments
Hmm, which ws4py version was failing then? |
I'm sorry but I don't know which version I had before I reverted back to 0.1.3. It would have been fairly recent, I'm guessing that the latest version would have been installed when I ran Applogies, I should have made a note of the version I was running in development before. |
No worries. Could you let me know the exatc version of Chrome you're using so that I can try to reproduce the pb? Were you running the simple chat demo? |
I'm using pyramid, eventlet and my library stargate on the server side. I have a loop that pulls a message off a zeromq socket, serialises it to json and sends it to the client. I'm running chromium Version 19.0.1084.52 on ubuntu and 21.0.1171.0 dev-m on windows. Just as a test I've installed ws4py latest version 0.2.1 via pip and the problem hasn't come back - maybe there was a bad intermediate version somewhere between 0.1.3 and 0.2.1 and it's been fixed now? |
Could well be as it has been an issue that had been reported already in the past. If you're happy enough with 0.2.1 then I'll let you close this ticket for now and reopen it if need be. |
It also seems that I had an issue with sending messages over the websocket faster than they could be dealt with by the client as well. However the masking issue certainly seems to be absent in the latest version of ws4py. Sorry to bother you with this! |
Clearly ws4py was never designed first and foremost for heavy load. Not that I'm against it but I wanted to have the functionality first. I'll be happy in making ws4py more load friendly in the future. |
I don't think the load is an issue with ws4py - it's more likely a badly designed client on my part :-) |
The latest version of chrome has started to fail for me with a message about the server sending a masked message. I found this commit: 19cfdb1 which seems seems to be addressing the issue.
If I install version 0.1.3 my websockets communication works again.
The text was updated successfully, but these errors were encountered: