New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

urlsplit in Python 2.6.1 and earlier doesn't parse ws or wss properly. #59

Closed

dsully opened this issue Sep 25, 2012 · 1 comment

Contributor

dsully commented Sep 25, 2012

>>> urlsplit('ws://localhost:8080/some-path')
SplitResult(scheme='ws', netloc='', path='//localhost:8080/some-path', query='', fragment='')

This results in 'host' being None, and an obtuse 'Connection Refused' message passed to close(), but without enough information to debug.

I see that 'websocket-client' has it's own _parse_url method that works around this bug:

https://github.com/liris/websocket-client/blob/master/websocket.py#L105

I'll try and work up a patch, if a solution like the above is reasonable?

Thanks

Contributor Author

dsully commented Sep 25, 2012

Fixed in d4e61d2

dsully closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment