Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

v3 greater refactor #43

Merged
merged 17 commits into from
Jan 14, 2019
Merged

v3 greater refactor #43

merged 17 commits into from
Jan 14, 2019

Conversation

davidpa9708
Copy link
Contributor

  • remove parameter settings for creating scroll manager instances
  • set public element property accessors
  • add misc for several utility functions

codeclimate[bot]
codeclimate bot reviewed Jan 11, 2019
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 28563 lines exceeds the maximum allowed for the inline comments feature.

@davidpa9708 davidpa9708 changed the title v3 clean v3 greater refactor Jan 11, 2019
@davidpa9708
test: add cypress
0f4bdab 
Squashed commit of the following:

commit 3269402
Author: David Perez Alvarez <david@leddgroup.com>
Date:   Sun Jan 13 14:00:18 2019 -0500

    test: add screenshots for readme

commit 1dcc05a
Author: David Perez Alvarez <david@leddgroup.com>
Date:   Sat Jan 12 02:02:30 2019 -0500

    test: refactor tests

commit ef1d5b5
Author: David Perez Alvarez <david@leddgroup.com>
Date:   Fri Jan 11 19:12:46 2019 -0500

    test: add basic cypress tests
codeclimate[bot]
codeclimate bot reviewed Jan 13, 2019
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 28143 lines exceeds the maximum allowed for the inline comments feature.

codeclimate[bot]
codeclimate bot reviewed Jan 13, 2019
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 28300 lines exceeds the maximum allowed for the inline comments feature.

codeclimate[bot]
codeclimate bot reviewed Jan 13, 2019
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 28318 lines exceeds the maximum allowed for the inline comments feature.

@davidpa9708
docs(readme): update README
d207779 
position => scrollPosition
@codeclimate
Copy link

codeclimate bot commented Jan 14, 2019

Code Climate has analyzed commit d207779 and detected 0 issues on this pull request.

View more on Code Climate.

codeclimate[bot]
codeclimate bot reviewed Jan 14, 2019
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 28318 lines exceeds the maximum allowed for the inline comments feature.

@davidpa9708 davidpa9708 merged commit 5f71a61 into master Jan 14, 2019
@davidpa9708 davidpa9708 deleted the dev branch January 14, 2019 00:30
@danielpza
Copy link
Member

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@codeclimate codeclimate[bot] codeclimate[bot] left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support watch elements
2 participants
@davidpa9708 @danielpza