Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle edge case of empty bounds on _getBoundsCenterZoom #5157

Merged
merged 3 commits into from
May 11, 2017
Merged

Handle edge case of empty bounds on _getBoundsCenterZoom #5157

merged 3 commits into from
May 11, 2017

Conversation

IvanSanchez
Copy link
Member

@IvanSanchez IvanSanchez commented Dec 1, 2016 •
edited
Loading

Fixes #5153.

Lacking unit tests right now, should be able to whip up one. There's a unit test, and I've made sure that it fails without the fix.

@IvanSanchez IvanSanchez mentioned this pull request Dec 1, 2016
Closed
@IvanSanchez IvanSanchez added this to the 1.0.3 milestone Dec 1, 2016
@IvanSanchez IvanSanchez modified the milestones: 1.0.3, 1.1 Jan 23, 2017
perliedman
perliedman approved these changes May 11, 2017
View reviewed changes
Copy link
Member

@perliedman perliedman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be one of the narrowest (figuratively as well as literally ;)) use cases I've seen, but 👍 FIX ALL THE THINGS!

@perliedman perliedman merged commit 873d4ca into master May 11, 2017
@mourner mourner deleted the zero-bounds branch March 20, 2020 10:26
@IvanSanchez IvanSanchez mentioned this pull request Nov 11, 2021
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perliedman perliedman perliedman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

Crash when fitBounds() to a zero-area bounds on uninitialized map
2 participants
@IvanSanchez @perliedman