Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request #667 breaks popups in IE #825

Closed
ajbeaven opened this issue Jul 24, 2012 · 0 comments
Closed

Pull request #667 breaks popups in IE #825

ajbeaven opened this issue Jul 24, 2012 · 0 comments

Comments

@ajbeaven
Copy link
Contributor

A bit of contentious code here it seems.

Pull request #667 seems to have broken popups in IE. This happens because in the onAdd function in L.Popup, uses setOpacity we make opacity 0, and then later on sets it to 1. setOpacity as it is written now means that we can never set opacity to 1.

Based on the description, I think it may also break #600

Obvious suggestion would be to revert #667, but there may be a way to improve the code to resolve both issues.

EDIT:
Created pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant