Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting the max time of Cooldown can result in time remaining being set to an invalid state #257

Closed
alice-i-cecile opened this issue Oct 12, 2022 · 1 comment
Closed

Setting the max time of Cooldown can result in time remaining being set to an invalid state #257

alice-i-cecile opened this issue Oct 12, 2022 · 1 comment
Labels
bug Something isn't working
Milestone
0.6

Comments

@alice-i-cecile
Copy link
Contributor

This value should be capped at max_time at all times.

Follow-up to #253. This needs a test to avoid regressions.
@alice-i-cecile alice-i-cecile added the bug Something isn't working label Oct 12, 2022
@alice-i-cecile alice-i-cecile added this to the 0.6 milestone Oct 12, 2022
@alice-i-cecile
Copy link
Contributor Author

Fixed in #253.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.6
Development

No branches or pull requests
1 participant
@alice-i-cecile