Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Node SASS v5.0.0 #205

Closed
owensgit opened this issue Feb 8, 2021 · 2 comments
Closed

Update to Node SASS v5.0.0 #205

owensgit opened this issue Feb 8, 2021 · 2 comments

Comments

@owensgit
Copy link
Contributor

owensgit commented Feb 8, 2021 •
edited
Loading

Being on Storybook v6 prevents us from updating to Node SASS v5.0.0, because it uses an older version of sass-loader which prevents the use of node-sass versions greater than v4. When we move to Storybook v6, we should update Node SASS as well.

Original PR that tried to update Node SASS, closed as it is blocked by Storybook - contains more info:
👉 #193
@andy-polhill
Copy link
Contributor

Links to #35

@elenagarrone
Copy link
Contributor

node-sass has been removed in favour of dart-sass in version 7.0.0.

https://github.com/Legal-and-General/canopy/releases/tag/v7.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@owensgit @andy-polhill @elenagarrone