Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix how buttons wrap within a Button Group Component #1481

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Fix how buttons wrap within a Button Group Component #1481

merged 1 commit into from
Nov 8, 2024

Conversation

markblandford
Copy link
Contributor

Description

Addresses spacing issues when there are buttons with long text, more than two buttons etc.

  • Fixes the test app which was broken due to a missing import of an icon.

Requirements

All screenshots have been taken from the test app.

Issue

Device Before After (fixed)
iPad Mini (768px) iPadMini-before iPadMini-after
iPad Prod 12" (1024px) iPadPro-before iPadPro-after
MacBook Pro (1440px) macBookPro-before macBookPro-after

Regression Check

Device Before After
iPhone 5 (320px) (regression test) iPhone5-before iPhone5-after

Checklist:

  • The commit messages follow the convention for this project
  • I have provided an adequate amount of test coverage
  • I have added the functionality to the test app
  • I have provided a story in storybook to document the changes
  • I have added the documentation
  • I have added any new public feature modules to public-api.ts

@markblandford
fix(button group): how the buttons wrap
19c1f60 
Addresses spacing issues when there are buttons with long text, more than two buttons etc.

* Fixes the test app which was broken due to a missing import of an icon.
@markblandford markblandford requested a review from a team as a code owner November 8, 2024 10:38
elenagarrone
elenagarrone approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@elenagarrone elenagarrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! thanks for fixing this!

@elenagarrone elenagarrone merged commit 8f4f194 into Legal-and-General:master Nov 8, 2024
3 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

🎉 This PR is included in version 12.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taraculpin taraculpin taraculpin approved these changes

@elenagarrone elenagarrone elenagarrone approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markblandford @elenagarrone @taraculpin