Admins can view all reports. Fixes #1810 #1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay I tested this locally, seems to work well. |
dessalines
commented
Oct 8, 2021
| community_moderator::table.on( | ||
| community_moderator::community_id | ||
| .eq(post::community_id) | ||
| .and(community_moderator::person_id.eq(my_person_id)), |
There was a problem hiding this comment.
This is the main thing here. Moved this filter to an admin check below, so it will only filter for the communities you mod if you aren't an admin.
Nutomic
reviewed
Oct 8, 2021
| pub fn get_report_count( | ||
| conn: &PgConnection, | ||
| my_person_id: PersonId, | ||
| admin: bool, | ||
| community_id: Option<CommunityId>, |
There was a problem hiding this comment.
How about just passing the PersonView, so you dont have to pass id and admin as separate params?
There was a problem hiding this comment.
I'd rather not pass whole views in order to build other views, all of these view methods should only require ids and bool flags. There's probably a way to do this even better with a smart query but this one in easy enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.