Add both (De)Serialize to all models #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
approved these changes
Oct 19, 2021
dessalines
approved these changes
Oct 19, 2021
There was a problem hiding this comment.
Seems fine and harmless to me. @Nutomic once you look this over and it passes, we can do another deploy so this gets pushed up to crates.io.
|
Sure, sounds good. |
|
@Tmpod K I'll start the deploy for this, should be |
|
Thank you. But you might want to wait just a couple of minutes.
I'm pushing the Cargo metadata PR ;)
|
dessalines
pushed a commit
that referenced
this pull request
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the dev Matrix channel, I'm adding both
SerializeandDeserializeto all models, so that clients can pull them from these crates instead of implementing everything themselves.