Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prod deploy script and clippy #1724

Merged
merged 16 commits into from
Aug 25, 2021
Merged

Fix prod deploy script and clippy #1724

merged 16 commits into from
Aug 25, 2021

Conversation

dessalines
Copy link
Member

No description provided.

@Nutomic
Copy link
Member

Nutomic commented Aug 24, 2021

Could you try again, either using image 1.51-buster (not slim), or installing pkg-config and openssl?

@dessalines
Copy link
Member Author

Buster fixed those errors, but there are new ones now: https://cloud.drone.io/LemmyNet/lemmy/1267/1/11

@Nutomic
Copy link
Member

Nutomic commented Aug 24, 2021

arbitrary expressions in key-value attributes are unstable

It compiles fine for me locally with cargo 1.54 (stable), so please try to update to that docker image.

@dessalines
Copy link
Member Author

dessalines commented Aug 24, 2021

Got a bit further: https://cloud.drone.io/LemmyNet/lemmy/1270/1/11

cp -r migrations crates/db_queries/
cargo workspaces publish --no-git-commit --allow-branch main --yes custom "0.11.4-rc.19"
error: The argument '--allow-branch <pattern>' cannot be used with '--no-git-commit'
cargo workspaces publish --no-git-commit --yes <BUMP> <CUSTOM

@Nutomic
Copy link
Member

Nutomic commented Aug 24, 2021

Those parameters for cargo workspaces are really confusingly named, maybe we can use --no-git-push instead of --no-git-commist? Or open an issue to ask the dev.

@dessalines
Copy link
Member Author

Seems like just --from-git is the correct one. We don't want any git actions, just publishing what's current.

@Nutomic
Copy link
Member

Nutomic commented Aug 25, 2021

Ah great. The truth is that I was too lazy to read all that and just glanced over it.

@dessalines
Copy link
Member Author

Nother error, no upload token found. : https://cloud.drone.io/LemmyNet/lemmy/1275/1/11

@Nutomic
Copy link
Member

Nutomic commented Aug 25, 2021

Oops forgot about that. I added my token as a secret (cargo_api_token). We need to read that into an env var as described in the link below, and then run cargo login $token.

https://docs.drone.io/secret/repository/

@Nutomic
Copy link
Member

Nutomic commented Aug 25, 2021

cargo login is failing, but thats probably because the secret is not available for pull requests. Also the version number on cargo.toml files is not being upgraded, maybe thats because youre not running the full release script. So its probably good to merge.

@dessalines dessalines merged commit af225a4 into main Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants