Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for lotide federation, make lotide groups fetchable #2035

Merged
merged 2 commits into from
Jan 17, 2022

Conversation

Nutomic
Copy link
Member

@Nutomic Nutomic commented Jan 13, 2022

I had a look at lotide federation, and decided to add some tests. Turns out there was a trivial problem that prevented lemmy from fetching lotide groups (they dont have a shared inbox on lotide). Users and comments were already working fine. The main problem is with posts, lotide represents them as Note. This makes very little sense based on the Activity Vocabulary. A Note is described as: "Represents a short written work typically less than a single paragraph in length". Lemmy uses a Page instead: "Represents a Web Page".

cc @vpzomtrrfrt Could you explain why it is implemented that way?

@vpzomtrrfrt
Copy link
Contributor

vpzomtrrfrt commented Jan 13, 2022

lotide uses Note for text posts and Page for links. I don't think Page really makes sense for text posts since they're no more pages than any other object. The length of the posts is whatever the user decides and I don't think that should necessarily impact the object type.

I believe Friendica uses Article for these, which seems reasonable, though in any case I think implementations should accept all three for incoming posts

@Nutomic
Copy link
Member Author

Nutomic commented Jan 13, 2022

I believe Friendica uses Article for these, which seems reasonable, though in any case I think implementations should accept all three for incoming posts

You're right, that sounds like the best solution.

@Nutomic Nutomic marked this pull request as draft January 13, 2022 01:43
@Nutomic
Copy link
Member Author

Nutomic commented Jan 13, 2022

Updated. This means that all these objects should federate now (at least in theory), and ensures that we dont make accidental breaking changes in the future. If there is anything else worth testing (more activities, tombstones, collections), please give me the json links and i will add them.

@Nutomic Nutomic marked this pull request as ready for review January 14, 2022 15:07
@vpzomtrrfrt
Copy link
Contributor

We have this list of most of the objects lotide uses: https://git.sr.ht/~vpzom/lotide/tree/master/item/doc/object-ids.md

@dessalines dessalines merged commit eea3308 into main Jan 17, 2022
dessalines pushed a commit that referenced this pull request Jan 27, 2022
* Add tests for lotide federation, make lotide groups fetchable

* Accept posts using Note type (and better error messages for tests)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants