Add tests for lotide federation, make lotide groups fetchable #2035
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a look at lotide federation, and decided to add some tests. Turns out there was a trivial problem that prevented lemmy from fetching lotide groups (they dont have a shared inbox on lotide). Users and comments were already working fine. The main problem is with posts, lotide represents them as
Note
. This makes very little sense based on the Activity Vocabulary. ANote
is described as: "Represents a short written work typically less than a single paragraph in length". Lemmy uses aPage
instead: "Represents a Web Page".cc @vpzomtrrfrt Could you explain why it is implemented that way?