Add tombstone tests, better test errors #2046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Created an issue on lotide to look into object permissions: https://todo.sr.ht/~vpzom/lotide/183 Votes are a bit tricky in this space since ideally they'd be anonymous but that doesn't seem practical |
|
It would probably work to make them visible for followers instead. But it might be clearer to define a new visibility level, like |
Nutomic
force-pushed
the
tombstone-tests
branch
from
81117cc
to
9bdb853
Compare
dessalines
approved these changes
Jan 20, 2022
|
No, making the permissions compatible is probably gonna take some time. |
dessalines
pushed a commit
that referenced
this pull request
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds test cases for Lemmy and Lotide tombstones. Also improves error reporting for failed tests.
@vpzomtrrfrt I tried to add tests for lotide Delete, Vote, Undo/Vote as well, but it seems like all of those are treated as private (i couldnt even access
/comments/{commentID}/likeswithout auth). In Lemmy all of those are explicitly marked as public (vote, delete). Thats because votes are federated to other instances (only sent as activity, not over any HTTP endpoint). For deletions there seems to be no reason to keep it private, as it contains only the Url.