Post creation from Mastodon (fixes #2590)

[Nutomic]

This lets Mastodon users create posts on Lemmy. As they dont send a name property, we instead take the beginning of the content.

[dessalines]

These shouldn't be removed, because the database needs them. Would be better to handle the missings in the apub code.

[Nutomic]

Fixed

[Nutomic]

To be honest Im not sure if this is really a good idea. Thats why i made a thread to discuss this.

https://lemmy.ml/post/705776

[dessalines]

There's one other thing I think needs to be added here, from @raphaeljolivet's suggestion:

#2590 (comment)

The first link found in the body(if there is one), could be the post link field.

[Nutomic]

I would rather keep it simple, the link isnt that important. Plus it could lead to unexpected behaviour if someone posts a list of multiple links, and only the first one gets emphasized by Lemmy.

Btw i cant tell why the api tests are failing, those errors seem completely unrelated.

[dessalines]

I'll try to run the federation tests locally and see if theres something wrong.

[dessalines]

I also verified that yes this does introduce a bug in the federation tests locally, I'm trying to figure out why.

[dessalines]

I've confirmed that this line is the one causing the test failures. Changing it back to a required string fixes them.

The error: LemmyError { message: Some("Cant receive page"), inner: Cant receive page, context: "SpanTrace" }

[Nutomic]

Thats the main change in this PR. If we remove the option, then posts from Mastodon wont work. And that error message doesnt mean anything to me, can you tell where exactly its coming from?

[dessalines]

All I could get from the massive output files to /tmp/lemmy_alpha.out :

2023-01-17T18:07:02.541885Z WARN Error encountered while processing the incoming HTTP request: lemmy_server::root_span_builder: Cant receive page: Cant receive page 0: lemmy_apub::activities::community::announce::receive at crates/apub/src/activities/community/announce.rs:149

I could post the whole file but I doubt it'd be much help.

Also this one:

cant accept local object from remote instance 0: lemmy_apub::objects::comment::verify at crates/apub/src/objects/comment.rs:135 1: lemmy_apub::activities::create_or_update::comment::verify at crates/apub/src/activities/create_or_update/comment.rs:156 2: lemmy_apub::activities::community::announce::receive at crates/apub/src/activities/community/announce.rs:149

[Nutomic]

Turns out in those failing tests, some comments were parsed as posts which broke things. I managed to create a workaround for this, a deserialize helper function which returns an error if the field inReplyTo exists on a post. Tnat means its really a comment. This fixes the problem because in case of enum deserialization (in activity_lists.rs), serde tries each item until it hits one which doesnt throw an error.

[ryanpeach]

So what are the "instructions" for doing this?

[slrgt]

@dessalines could you post an example of how we should format posts on mastodon so they can with on Lemmy?

interoperability between the fediverse is so amazing!

[ghobs91]

@dessalines could you post an example of how we should format posts on mastodon so they can with on Lemmy?

interoperability between the fediverse is so amazing!

You would format it like this:

Title
Link
tag the lemmy community on mastodon

So for example, I posted this on Mastodon:

City council passed a measure calling for 30% tree canopy cover by 2035
forestforall.nyc/nyc-urban-for
@nyc@lemmy.ml

and that created this post on Lemmy: https://lemmy.ml/post/8767924

[slrgt]

@ghobs91 where would the body of the lemmy post go? Is it possible to add a body or images/videos?