Searching Federated NSFW Communities

[ginobo]

• Did you check to see if this issue already exists?
• Is this only a single bug? Do not put multiple bugs in one issue.
• Is this a question or discussion? Don't use this, use https://lemmy.ml/c/lemmy_support .
• Is this a UI / front end issue? Use the lemmy-ui repo.

Issue Summary

Federated NSFW communities are not discoverable via the "Communities" tab

Steps to Reproduce

1. Open up Lemmy on an instance with NSFW enabled
2. Click "Communities"
3. Search for the name of a NSFW instance on a different instance (not in fully qualified !name@instance but rather just as name)

• Note: searching this way does work for SFW communites

5. Observe that it does not come up

Technical details

While I do not have logs as I am only a user, I suspect it is an issue with NSFW communities not being publicly viewable without an account, however I think it would be reasonable that they should be searchable if the account you are on has nsfw enabled.

Federated NSFW communities do come up if you search their fully qualified name !name@instance

[tgxn]

I also noticed that since their 0.18.0 upgrade? it seems that https://lemmynsfw.com/api/v3/community/list has stopped returning NSFW communities. (I am unauthenticated)

Seems related to #1320.

I propose adding show_nsfw as an optional query param #3363

[tgxn]

The backend change to allow listing of these is implemented in #3363

This is nowa UI issue - We need to add a toggle on the community list page "Show/Hide NSFW" - With the default to whatever the user has configured (or false if they are logged out)