Skip to content

Commit

Permalink
Breaking: also drop Node.js 16 and Electron < 30
Browse files Browse the repository at this point in the history
Follow-up for c177f3c. Older Electron versions will still work
fine, but we stop testing them.

Category: removal
  • Loading branch information
vweevers committed Oct 20, 2024
1 parent 20efc35 commit e18d5c7
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 27 deletions.
8 changes: 1 addition & 7 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,8 @@ jobs:
- name: Set up node
uses: actions/setup-node@v4
with:
node-version: 16
node-version: 18
architecture: ${{ matrix.arch }}
# Temporary fix for https://github.com/nodejs/node-gyp/issues/2869
# TODO: instead bump node-gyp to >= 10.0.0 (drops Node.js < 16.14)
- name: Use Python 3.11
uses: actions/setup-python@v5
with:
python-version: '3.11'
- name: Install
run: npm install --ignore-scripts
- name: Prebuild
Expand Down
8 changes: 1 addition & 7 deletions .github/workflows/smoke.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,8 @@ jobs:
- name: Set up node
uses: actions/setup-node@v4
with:
node-version: 16
node-version: 18
architecture: ${{ matrix.arch }}
# Temporary fix for https://github.com/nodejs/node-gyp/issues/2869
# TODO: instead bump node-gyp to >= 10.0.0 (drops Node.js < 16.14)
- name: Use Python 3.11
uses: actions/setup-python@v5
with:
python-version: '3.11'
- name: Install
run: npm install --ignore-scripts
- name: Prebuild
Expand Down
10 changes: 2 additions & 8 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
node: [16, 18, 20]
node: [18, 20, 22]
arch: [x86, x64]
exclude:
- { os: ubuntu-latest, arch: x86 }
Expand All @@ -24,12 +24,6 @@ jobs:
with:
node-version: ${{ matrix.node }}
architecture: ${{ matrix.arch }}
# Temporary fix for https://github.com/nodejs/node-gyp/issues/2869
# TODO: instead bump node-gyp to >= 10.0.0 (drops Node.js < 16.14)
- name: Use Python 3.11
uses: actions/setup-python@v5
with:
python-version: '3.11'
- name: Install
run: npm install
- name: Test
Expand All @@ -41,7 +35,7 @@ jobs:
with:
file: coverage/lcov.info
- name: Test Electron
if: ${{ matrix.node == '16' }}
if: ${{ matrix.node == '18' }}
uses: GabrielBB/xvfb-action@v1
with:
run: npm run test-electron
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ const xyz = db.sublevel<string, any>('xyz', { valueEncoding: 'json' })

## Supported Platforms

We aim to support _at least_ Active LTS and Current Node.js releases, Electron >= 18, as well as any future Node.js and Electron releases thanks to [Node-API](https://nodejs.org/api/n-api.html).
We aim to support Active LTS and Current Node.js releases, Electron >= 30, as well as any future Node.js and Electron releases thanks to [Node-API](https://nodejs.org/api/n-api.html).

The `classic-level` npm package ships with prebuilt binaries for popular 64-bit platforms as well as ARM, M1, Android (built against Node.js core rather than the [`nodejs-mobile`](https://github.com/JaneaSystems/nodejs-mobile) fork), Alpine (musl), Windows 32-bit, Linux flavors with an old glibc (Debian 8, Ubuntu 14.04, RHEL 7, CentOS 7) and is known to work on:

Expand Down
2 changes: 1 addition & 1 deletion UPGRADING.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ This document describes breaking changes and how to upgrade. For a complete list

## 2.0.0

This release upgrades to `abstract-level` 2.0.0 which adds [hooks](https://github.com/Level/abstract-level#hooks) and drops callbacks, not-found errors and support of Node.js < 16. Please refer to the [upgrade guide of `abstract-level`](https://github.com/Level/abstract-level/blob/v2.0.0/UPGRADING.md). The only thing to add is that the additional methods of `classic-level` like `db.approximateSize()` also don't support callbacks anymore.
This release upgrades to `abstract-level` 2.0.0 which adds [hooks](https://github.com/Level/abstract-level#hooks) and drops callbacks, not-found errors and support of Node.js < 16. Please refer to the [upgrade guide of `abstract-level`](https://github.com/Level/abstract-level/blob/v2.0.0/UPGRADING.md). The only thing to add is that `classic-level` also drops Node.js 16 and Electron < 30, and that the additional methods of `classic-level` like `db.approximateSize()` similarly don't support callbacks anymore.

## 1.0.0

Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,11 @@
"cross-env": "^7.0.3",
"dependency-check": "^4.1.0",
"du": "^1.0.0",
"electron": "^18.3.15",
"electron": "^30.5.1",
"glob": "^8.0.1",
"hallmark": "^4.1.0",
"mkfiletree": "^2.0.0",
"node-gyp": "^9.0.0",
"node-gyp": "^10.2.0",
"nyc": "^15.0.0",
"prebuildify": "^5.0.0",
"prebuildify-ci": "^1.0.4",
Expand All @@ -66,6 +66,6 @@
"level"
],
"engines": {
"node": ">=16"
"node": ">=18"
}
}

0 comments on commit e18d5c7

Please sign in to comment.