Skip to content
This repository has been archived by the owner on Dec 1, 2024. It is now read-only.

An in-range update of abstract-leveldown is breaking the build 🚨 #443

Closed
greenkeeper bot opened this issue Feb 9, 2018 · 8 comments
Closed

An in-range update of abstract-leveldown is breaking the build 🚨 #443

greenkeeper bot opened this issue Feb 9, 2018 · 8 comments
Assignees

Comments

@greenkeeper
Copy link
Contributor

greenkeeper bot commented Feb 9, 2018

Version 4.0.1 of abstract-leveldown was just published.

Branch Build failing 🚨
Dependency abstract-leveldown
Current Version 4.0.0
Type dependency

This version is covered by your current version range and after updating it in your project the build failed.

abstract-leveldown is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • continuous-integration/travis-ci/push The Travis CI build is in progress Details
  • continuous-integration/appveyor/branch AppVeyor build failed Details

Commits

The new version differs by 13 commits.

  • 2320f10 4.0.1
  • 7d41bd7 prepare changelog for 4.0.1
  • f946325 Update changelog (#199)
  • 014ff8a Merge pull request #195 from Level/typescript
  • c68595f add TypeScript readme section with stability badge
  • 5eb28af add TypeScript smoke test
  • b1ed564 define default methods on prototype to please TypeScript
  • 38b3706 use ES6 classes in tests to please TypeScript
  • c2f400e remove obsolete parameters from tests
  • b353fb4 update TypeScript typings for v4
  • 268e59b run test suite in TypeScript in addition to Node.js
  • e78a21a Merge pull request #196 from ralphtheninja/master
  • ef61b68 readme: link to upgrade guide

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

@vweevers
Copy link
Member

vweevers commented Feb 9, 2018

Shit, what happened here?

@vweevers
Copy link
Member

vweevers commented Feb 9, 2018

@ralphtheninja help

@vweevers
Copy link
Member

vweevers commented Feb 9, 2018

Level/abstract-leveldown#195 broke leveldown because the iterator code used to be:

return self._next(function () {	
      self._nexting = false	
      callback.apply(null, arguments)	
})

And leveldown returned this from _next. I will fix this in abstract-leveldown.

@ralphtheninja
Copy link
Member

@vweevers Oh okay. I didn't see that coming. No worries. We should really prioritize a canary.

@vweevers
Copy link
Member

vweevers commented Feb 9, 2018

I did not mean to close this. @ralphtheninja will greenkeeper trigger another build?

@vweevers
Copy link
Member

vweevers commented Feb 9, 2018

Curious to see if Greenkeeper will update this ticket if I reopen.

@vweevers vweevers reopened this Feb 9, 2018
@vweevers
Copy link
Member

Builds are green.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants