-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clear() #669
Add clear() #669
Conversation
@@ -446,6 +464,7 @@ const main = async () => { | |||
| `put` | Key has been updated | `key, value` (any) | | |||
| `del` | Key has been deleted | `key` (any) | | |||
| `batch` | Batch has executed | `operations` (array) | | |||
| `clear` | Entries were deleted | `options` (object) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not 100% sure about the argument (options
). I figured a listener might want to inspect the range options, to find out what was deleted. But that information is not exact (in contrast with the put
, del
and batch
events that tell you exactly which keys were modified).
@ralphtheninja Before we release this I want to think about adding a way to feature-detect it. A module like That db may be |
Maybe we could start by adding a |
Yeah, we could make a patch release on |
It's time for manifests (again), I think. Level/community#42 (comment) |
I was thinking manifest just now :) |
I propose the following timeline:
Edit for the record: it turned out |
Closes #648.
Blocked by Level/deferred-leveldown#72 and Level/encoding-down#89.