Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passing error object to notify raises UnexpectedTypeException #33

Closed
Li357 opened this issue Oct 24, 2019 · 0 comments · Fixed by #34
Closed

Passing error object to notify raises UnexpectedTypeException #33

Li357 opened this issue Oct 24, 2019 · 0 comments · Fixed by #34

Comments

@Li357
Copy link
Owner

Li357 commented Oct 24, 2019

WHS/packages/app/src/screens/Settings.tsx

Line 57 in 41288c2

notify('Error', error);

error is an Error object, not a string.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make error notification and reporting consistent across screens, refactor code Li357/WHS
1 participant
@Li357