-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scheduling early transition to Workbench #62
Comments
@tobyhodges Let me slack Abigail and Owen. I for one think this is a great idea. |
@tobyhodges We've discussed and are good to move ahead with the early transition. |
Excellent news, thank you all for your help. Watch out for pull requests from @zkamvar and me in the coming days, as we prepare for the transition. |
Thank you for participating in the early transition to The Workbench. I have been able to render a preview of your lesson at https://fishtree-attempt.github.io/lc-marcedit. I am tracking issues for your lesson in carpentries/lesson-transition#64. I will be updating the preview next week as I work on any remaining issues. Please inspect the preview and make note in carpentries/lesson-transition#64 if you see anything that needs to be fixed (e.g extra templating, narrow tables, or malformed text). |
Thanks @zkamvar . I will take some time today and next week. Is it ok with you if we have until at least next Friday to review everything? I'm out for 2 days and get back to the office on Wednesday. |
Hi @abigailsparling @jenmawe @ostephens we are getting ready for an early transition for this lesson, and we have prepared a schedule for early lesson transitions. Please check that document to see the date we have planned for transitioning this lesson, and adjust the sheet if a different date would be more convenient for you (no more than three lessons per day, please!). The README sheet gives more information. If we don't hear from you, we will go ahead with the transition on the date shown in that document. |
@zkamvar We looked at the lesson and found the following things that appear a little off to us:
|
Hi @jenmawe, thank you for your comments. Please note that while I can fix a lot of things in the automation, there are some things that are much more efficient to fix in the source (e.g. #67).
Ah yes, the nefarious liquid comment. I'll try to get something to clean that since it's definitely something that should be scrubbed.
This is an off-by-one error from me. I'll fix it so that the objectives are a the top. That being said, I'm not sure why the callout at the top is not working :(
yes, wrap all the MARC tags (especially dollar signs) in backticks like #67
I'm not sure I understand this question. In any case, this is not something I can work on during the transition. |
Hi @zkamvar. This is great information to have. We were wondering what you could do on your end and what needed to be done on ours. Once the transition is done, we'll look at those tables in all our lessons to make sure that they display correctly. We are also going to look at some of our images as well. |
I have addressed the issues with the headings. It will be rebuilt on the preview soon |
Headings look great @zkamvar |
I have opened #69, which I think will fix the issue of that table in the first callout of episode 3 not being rendered in the Workbench version of the lesson. |
Nice. Thank you, Toby. I will check it out |
It looks like that DID fix the issue THANKYOU!. I'm still not exactly sure why it was problematic in the first place, but I'm okay with moving forward. Note for the maintainers: a lot of the tables are encoded in HTML. I would recommend, pasting the HTML source from these tables into https://pandoc.org/try/ and converting them from |
Thanks @tobyhodges and @zkamvar. Do we consider the transition over at this point? Another question, we're trying to get this lesson to the alpha stage. Do you have any recommendation for that? Jennifer |
Not quite yet. The transition will happen tomorrow. This process was to address any issues that needed to be fixed before the automated transition. I will make comments here during my progress transitioning tomorrow. See swcarpentry/shell-novice-es#65 (comment) for an example. |
This lesson will be converted to use The Carpentries Workbench
If you no longer wish to have write access to this repository, you do not
If you wish to regain write access, please re-clone the repository on your machine and If you have any questions, please reply here and tag @zkamvar |
The deed is done. The infrastructure takes a few minutes to bootstrap and cache the packages for the lesson build. Once the build is done, I will switch github pages to deploy from the Thank you all for your enthusiasm and your patience! |
The Workbench version is now live: https://librarycarpentry.github.io/lc-marcedit/ In addition, here is map of commits that were changed during the transition |
@zkamvar Thank you for all the work you've done to switch us to Workbench! And also a big thanks to @tobyhodges. I've gone ahead and forked this report. I am ready for write access 🚀 |
@jenmawe I have granted you access to the maintianer team. This repository was peculiar in that you were listed as an outside collaborator. You will find an invite to the team in your email. |
@zkamvar I am ready for write access 🚀 |
@abigailsparling I have granted you access to the maintianer team. This repository was peculiar in that you were listed as an outside collaborator. You will find an invite to the team in your email. |
Hi @jt14den and @ostephens - You have not yet responded here to report that you completed the steps listed by @zkamvar above to regain your Maintainer access to this repository. The lesson infrastructure transition required a second Maintainer team to be temporarily created for all lessons, which can only be removed when all Maintainers have confirmed that they are ready to have their access restored. Maintenance of both teams is not sustainable for The Carpentries in the long run. At the beginning of November 2023 (note the deadline has been extended) we will remove access for Maintainers who have not taken the necessary action to continue working on the repository. The Curriculum Team is truly grateful for everything you have already done as a Maintainer and we do not want to lose you! But we also understand that circumstances change and you may no longer have capacity to continue in your role. If you wish to retain your access and keep supporting the community, please follow the steps above then confirm that you are ready by commenting I am ready for write access 🚀 on this thread before the end of your day on Wednesday 1st November. |
@zkamvar I am ready for write access 🚀 |
Thank you @ostephens. Zhian is out of office for the next few days but we will restore your access ASAP |
I am ready for write access 🚀 |
Congratulations, everyone has write access! |
Short version: are you are willing to volunteer your lesson for early transition to The Carpentries Workbench
infrastructure?
Longer version below:
As I hope you are already aware, @zkamvar and the rest of the Curriculum Team are preparing to roll out the new lesson infrastructure, The Carpentries Workbench, across all of The Carpentries official lessons in early May 2023. This means that all Data Carpentry, Library Carpentry, and Software Carpentry lesson repositories will be modified to adopt the new infrastructure at the end of this month.
As you might imagine, coordinating a rollout like this involves a large amount of time and effort, and one thing that will really help us to keep to the schedule and avoid disruption for the community is to be able to prepare some lessons for
transition before the 1st May deadline.
With this in mind, I invite you to volunteer to schedule an early transition for theis lesson repository. If you expect to have time to adopt the Workbench version of the lesson repository in the next couple of weeks, please reply to let me know. As lesson Maintainers, these are the things you will need to be prepared to do for the transition:
If you are willing and able to help us ensure a smooth rollout of the Workbench, please reply to let me know that you are happy to volunteer your lesson for early transition. If there is a specific date you would like the transition to take place (or that we should avoid), please also mention that.
The text was updated successfully, but these errors were encountered: