Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

JSON chat support #93

Open
TheDGOfficial opened this issue Nov 3, 2019 · 0 comments
Open

JSON chat support #93

TheDGOfficial opened this issue Nov 3, 2019 · 0 comments
Assignees
Labels
priority: medium A medium priority issue or pull request state: help wanted Extra attention is needed type: feature A good feature
Milestone

Comments

@TheDGOfficial
Copy link
Member

Is your feature request related to a problem? Please describe.
The skQuery's JSON expression is great, but it has problems and not directly integrated into Skript. There is a JSON-chat system in the new Skript eco-system, in the SkriptLang fork, dev27+ versions.

Describe the solution you'd like
Perhaps we can also integrate it to the LifeSkript, we are currently using skQuery's system but the JSON-chat one is directly integrated into Skript, and it works flawlessly.

Describe alternatives you've considered
We can also use skQuery's thing or copy it into our fork and fix its problems.

Additional information
I don't want to create a non-backward compatible Skript version, so it should NOT include the latest security fix where if the message contains an expression, variable, chat color or JSON it must be externally "colored" via the colo[u]red %strings% syntax.

The JSON one, of course, a security risk because the user can add a command to a message and this dangerous, but the color ones don't. We can always use the uncolored expression to remove colors.

So we should use another effect or mark pattern (e.g send JSON) that overrides skQuery's thing.

@TheDGOfficial TheDGOfficial added state: help wanted Extra attention is needed type: feature A good feature priority: medium A medium priority issue or pull request labels Nov 3, 2019
@TheDGOfficial TheDGOfficial added this to the 2.2.18 milestone Nov 3, 2019
@TheDGOfficial TheDGOfficial self-assigned this Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: medium A medium priority issue or pull request state: help wanted Extra attention is needed type: feature A good feature
Projects
None yet
Development

No branches or pull requests

1 participant