Fix flakyness in tests related to torch.unique with dim=None
#2650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
requested review from
Borda,
justusschock and
stancld
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2650 +/- ##
========================================
- Coverage 69% 41% -27%
========================================
Files 316 316
Lines 17745 17745
========================================
- Hits 12185 7307 -4878
- Misses 5560 10438 +4878 |
|
seems like added retry helped but it would still be worse to know what is happening there... |
|
@Borda should be good now, found that the issue had to do with how |
Borda
approved these changes
Aug 27, 2024
SkafteNicki
changed the title
torch.unique with dim=None
Borda
pushed a commit
that referenced
this pull request
Sep 11, 2024
* correct check * found the problem --------- Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com> Co-authored-by: jirka <jirka.borovec@seznam.cz> (cherry picked from commit 0313c6b)
Borda
pushed a commit
that referenced
this pull request
Sep 13, 2024
* correct check * found the problem --------- Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com> Co-authored-by: jirka <jirka.borovec@seznam.cz> (cherry picked from commit 0313c6b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
One of test seems to be flaky. See for example this CI run:
https://github.com/Lightning-AI/torchmetrics/actions/runs/10037067157/job/27736179139?pr=2636#step:16:839
Trying to debug why this is happening
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2650.org.readthedocs.build/en/2650/