Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text: re-adding Chrf implementation [reverted] #2697

Merged
merged 5 commits into from
Aug 28, 2024
Merged

text: re-adding Chrf implementation [reverted] #2697

merged 5 commits into from
Aug 28, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Aug 20, 2024

This reverts commit 663f06d.

What does this PR do?

re-adding Chrf temp drooped in #2668

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2697.org.readthedocs.build/en/2697/

@Borda Borda marked this pull request as ready for review August 20, 2024 20:05
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 85.53459% with 23 lines in your changes missing coverage. Please review.

Project coverage is 39%. Comparing base (ef22554) to head (dd9c0c7).

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2697     +/-   ##
========================================
- Coverage      69%     39%    -29%     
========================================
  Files         316     316             
  Lines       17745   17897    +152     
========================================
- Hits        12185    7025   -5160     
- Misses       5560   10872   +5312     

@stancld stancld enabled auto-merge (squash) August 22, 2024 07:13
@SkafteNicki SkafteNicki added this to the v1.5.0 milestone Aug 27, 2024
@mergify mergify bot added the ready label Aug 27, 2024
@Borda
Copy link
Member Author

Borda commented Aug 27, 2024

Waiting on @m-popovic to approve it... 🦩

@stancld stancld merged commit d9d37d8 into master Aug 28, 2024
60 of 61 checks passed
@stancld stancld deleted the add/chfr branch August 28, 2024 09:59
@Borda
Copy link
Member Author

Borda commented Aug 28, 2024

@stancld pls read #2697 (comment)

@Borda Borda restored the add/chfr branch August 28, 2024 10:03
Copy link
Contributor

mergify bot commented Aug 28, 2024

⚠️ The sha of the head commit of this PR conflicts with #2701. Mergify cannot evaluate rules on this PR. ⚠️

@Borda Borda mentioned this pull request Aug 28, 2024
5 tasks
@Borda
Copy link
Member Author

Borda commented Aug 28, 2024

reopen in #2701

@Borda Borda changed the title text: re-adding Chrf implementation text: re-adding Chrf implementation [reverted] Aug 29, 2024
Copy link
Contributor

mergify bot commented Aug 29, 2024

⚠️ The sha of the head commit of this PR conflicts with #2701. Mergify cannot evaluate rules on this PR. ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants