Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some callbacks for debugging and visualization #194

Closed
awaelchli opened this issue Sep 9, 2020 · 5 comments · Fixed by #465
Closed

Some callbacks for debugging and visualization #194

awaelchli opened this issue Sep 9, 2020 · 5 comments · Fixed by #465
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@awaelchli
Copy link
Contributor

awaelchli commented Sep 9, 2020

🚀 Feature

Do you have interest in adding any of these callbacks here?
https://github.com/awaelchli/pytorch-lightning-snippets
Can also make an issue for each one, just wanted to know first if there is a desire for more callbacks in PL bolts?

TrainingDataMonitor: logs histogram of what goes into training_step
ModuleDataMonitor: logs histogram of what goes into each submodule in LightningModule
BatchNormVerification: checks (heuristic) if you have a bias before a normalization layer
BatchGradientVerification: checks that your network does not mix data across batch dim.

Motivation

  • Have more callbacks in PL bolts
  • useful for debugging and visualization of training

Additional context

Happy to help maintain it and adapt to your needs.

@awaelchli awaelchli added enhancement New feature or request help wanted Extra attention is needed labels Sep 9, 2020
@github-actions
Copy link

github-actions bot commented Sep 9, 2020

Hi! thanks for your contribution!, great first issue!

@nateraw
Copy link
Contributor

nateraw commented Sep 11, 2020

These are 🔥 . Let's do it.

@stale
Copy link

stale bot commented Nov 10, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Nov 10, 2020
@TylerYep
Copy link

TylerYep commented Nov 19, 2020

@awaelchli Are you still planning on merging all of these? I figured since you already wrote the code, the verifiers might as well be merged in :)

@stale stale bot removed the won't fix This will not be worked on label Nov 19, 2020
@awaelchli
Copy link
Contributor Author

@TylerYep oh yes, thanks for the reminder.
Not sure how useful the batch norm verification is in general but the gradient check definitely, that's awesome!
I will prepare a PR

@Borda Borda added this to the v0.3 milestone Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants