Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

clean kwargs in the data module #253

Closed
edgarriba opened this issue Apr 29, 2021 · 0 comments · Fixed by #256
Closed

clean kwargs in the data module #253

edgarriba opened this issue Apr 29, 2021 · 0 comments · Fixed by #256
Assignees
@edgarriba
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone
v0.3

Comments

@edgarriba
Copy link
Contributor

edgarriba commented Apr 29, 2021 •
edited
Loading

🚀 Feature

There are some places where we abuse of using kwargs which makes a bit unreadable the code and led to bugs when we pass some arguments in the DataModule.

The idea is to remove some kwargs and explicit and needed arguments when we create the data module.

https://github.com/PyTorchLightning/lightning-flash/blob/master/flash/data/data_module.py#L430-L433
@edgarriba edgarriba added enhancement New feature or request help wanted Extra attention is needed labels Apr 29, 2021
@edgarriba edgarriba self-assigned this Apr 29, 2021
@edenlightning edenlightning added this to the 0.3 milestone May 2, 2021
@edgarriba edgarriba linked a pull request May 3, 2021 that will close this issue
[1/N] Data Sources #256
Merged
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@edgarriba edgarriba

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
v0.3
Development

Successfully merging a pull request may close this issue.

[1/N] Data Sources Lightning-Universe/lightning-flash
2 participants
@edgarriba @edenlightning