Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sMembers returns Future[Set[String]] #6

Closed
inanna-malick opened this issue Dec 31, 2013 · 2 comments
Closed

sMembers returns Future[Set[String]] #6

inanna-malick opened this issue Dec 31, 2013 · 2 comments
Assignees
Labels

Comments

@inanna-malick
Copy link

sMembers[A](key: String)(implicit opts: CommandOptions = DefaultCommandOptions, parser: Parser[A] = StringParser): Future[Set[String]]

I believe sMembers should attempt to parse each member of the given set with the provided Parser[A], returning a Set[A] if successful. This would be more in line with other methods such as get[A].

@curreli
Copy link
Contributor

curreli commented Dec 31, 2013

Indeed, it should return Future[Set[A]].

Good catch, thanks for reporting!

@ghost ghost assigned curreli Dec 31, 2013
@curreli
Copy link
Contributor

curreli commented Dec 31, 2013

Fixed here: 939af3d

@curreli curreli closed this as completed Dec 31, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants