Menu Widget has stopped working (OSOE-897)

[barthamark]

Menu Widget doesn't provide the UI to either pick a menu or edit a new one. Probably it stopped working after an Orchard Core upgrade.

Jira issue

[sarahelsaig]

The menu widget processes INavigationProvider services where the navigation name is "main" (see MainMenuNavigationProviderBase) Just like with the admin menus that come from navigation providers, these are added programmatically and can't be edited from the dashboard.

Lombiq.BaseTheme adds a provider called MainMenuNavigationProvider that uses stock OC menu convention. It looks for a content item that has a MenuItemsListPart and an alias of "main-menu" so you can edit this content item without the need for a separate UI. If you want to be fancy, you can use OrchardCore.AdminMenu to add a link pointing directly to its content item editor, OC's Blog recipe does this for example. (btw we have UI tests for this so we'd know if it was broken)

I don't think there is anything that needs to be done here. Please confirm.

[barthamark]

It caused confusion with the client and rightfully so. We should either rename it (e.g., NavigationWidget or MenuPlaceholderWidget) and add description to it where it says what it does exactly. Thoughts?

[sarahelsaig]

Renaming would be an unnecessary breaking change with not that much of an improvement in my eyes. I guess we could add further elaboration into the readme and a .WithDescription() to the widget's type definition in the migrations.

[barthamark]

How about renaming the Display Name? Also adding Description.

[sarahelsaig]

I could go for "Menu Navigation Provider Widget" as display name, if that helps.

[Piedone]

So this is only about adding a display name?

[sarahelsaig]

Yes, also to add some note in the readme.

[Piedone]

OK, thanks. Sounds like an easy issue, then.