Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

number of retries with sendConfirmed frame #37

Closed
FoujanetG opened this issue Jan 15, 2016 · 2 comments
Closed

number of retries with sendConfirmed frame #37

FoujanetG opened this issue Jan 15, 2016 · 2 comments

Comments

@FoujanetG
Copy link

Hi,

I think there is a problem with the dafault value of AckTimeoutRetriesCounter.

When I configure LoRaMacSendConfirmedFrame with nbRetries=1, the frame is sent one time( with ACK timeOut of course). and if configure nbRetries=2, the frame is sent two times.

Normally, the number of retrie is in more of the first frame. So if the value of nbRetries is 3, 4 frames are sent if there is no Acknowledge.

Thanks

GF.

@jmalangoni
Copy link

iirc if nbRetries = 0 the value reverts to some default. so nbRetries actually represents "number of retries - 1"? If so, maybe this just needs to be documented better... EDIT: this is the case for NbRep in LinkADRReq MAC command, NOT for LoRaMacSendConfirmedFrame.

Looks to me now that AckTimeoutRetries and AckTimeoutRetriesCounter could use zero as a base with a few additional changes, but at this point it could break compatibility for anyone using the new API and the value of McpsConfirm.NbRetries. Again, maybe this just needs to be documented better?

@djaeckle
Copy link

Hi,

thanks for the report. Please intrepret the attribute "nbRetries" as the "number of trials". We will update the name of the attribute "nbRetries" and also the related documentation in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants