Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some lottie animations do not work on version 3.5.0 and above #129

Open
rahulsuresh-git opened this issue Feb 6, 2023 · 4 comments
Open
Labels

Comments

@rahulsuresh-git
Copy link

Overview

We've identified that some of our lottie animations don't load when we use @lottiefiles/react-lottie-player:3.5.x
This issue has prevented us from using the latest version of this package due to which we are not able to utilize the fixes that have been pushed in future versions. For example, the error event doesn't work on v3.4.9 (#105).

This issue is clearly reproducible. I'm adding the codesandbox links below.

Consuming repo

Working version (@lottiefiles/react-lottie-player:3.4.9):
https://codesandbox.io/s/un-bug-react-lottie-player-3-4-9-q6gldg?file=/src/App.js

Issue version (@lottiefiles/react-lottie-player:3.5.x):
https://codesandbox.io/s/un-bug-react-lottie-player-3-5-0-hjqx4y?file=/src/App.js

The lottie JSON are available inside the codesandbox repo above.

Things we've tried:

  1. Upload the breaking JSON file to LottieFiles website where it works as intended. We tried downloading a fresh JSON from the site and loading it locally, but it doesn't work either.
  2. We've tried switching to React 17 but the issue still happens irrespective of React version.
  3. Tried multiple other lottie react packages like https://github.com/airbnb/lottie-web, including native implementation using https://github.com/LottieFiles/lottie-player but faced the same issue on latest versions.

We would appreciate if this is resolved at the earliest. Let me know if you require further information :)

@samuelOsborne
Copy link
Member

Hi @rahulsuresh-git This issue would be best posted on

https://github.com/airbnb/lottie-web

as thats what we're wrapping in this react player.

@rahulsuresh-git
Copy link
Author

Hey @samuelOsborne, thanks for the reply. I thought that all the other packages used and wrapped over this package, since this is the package provided by the company that created Lottie.

Is the airbnb package the official package for react implementation of Lottie?

P.S: I'm curious on why this isn't the official package? :)

@samuelOsborne
Copy link
Member

@rahulsuresh-git its the other way round :) The airbnb package is the official implementation of Lottie. This repository is a react wrapper on top of it with extra helpers

@github-actions
Copy link

github-actions bot commented Apr 8, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.

@github-actions github-actions bot added the stale label Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants