feat(h5p-server): core update #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sr258
force-pushed
the
refactor/core-update
branch
from
3830f15 to
86152c0
Compare
sr258
force-pushed
the
refactor/core-update
branch
from
86152c0 to
a4532fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1312 once complete.
If we merge this, the current (unstable?) master of the H5P core is referenced and downloaded. There wasn't too much new stuff in it except for the H5P content hub.
The consuming part of content hub is implemented (it's much easier), but no the sharing part. I don't think this is critical at this moment, as we still remain compatible. Sharing to the content hub simply a feature that we don't offer yet. I think it's better to wait until there's a stable and published version of it.