Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error handling. There might be notices #268

Merged
merged 3 commits into from
Sep 16, 2015

Conversation

m0ppers
Copy link
Contributor

@m0ppers m0ppers commented Jul 1, 2014

PHP Notice: Undefined index: oauth_token in /base/data/home/apps/smenu-2-day/1.376922300240819864/vendor/lusitanian/oauth/src/OAuth/OAuth1/Service/Twitter.php on line 110
W 2014-07-01 10:01:29.652
PHP Notice: Undefined index: oauth_token_secret in /base/data/home/apps/s
menu-2-day/1.376922300240819864/vendor/lusitanian/oauth/src/OAuth/OAuth1/Service/Twitter.php on line 111

etc. and i have no idea what is going on

$this->setExpectedException('\\OAuth\\Common\\Http\\Exception\\TokenResponseException');
$method = new \ReflectionMethod(get_class($service), 'parseAccessTokenResponse');
$method->setAccessible(true);
$method->invokeArgs($service, ["error=hihihaha"]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆

@elliotchance
Copy link
Collaborator

This looks good, please pull in the latest master to fix the build.

@m0ppers
Copy link
Contributor Author

m0ppers commented Sep 16, 2015

merged master..ready to merge back? :O

elliotchance added a commit that referenced this pull request Sep 16, 2015
Better error handling. There might be notices
@elliotchance elliotchance merged commit 5187eb6 into daviddesberg:master Sep 16, 2015
@elliotchance
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants