Add bitrix24 service #322
Merged
Add bitrix24 service #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 16, 2014 04:41
|
https://travis-ci.org/Lusitanian/PHPoAuthLib/jobs/41131535 |
| <?php | ||
|
|
||
| /** | ||
| * Example of retrieving an authentication token of the Github service |
|
@ruscon please pull in the latest master to rerun the build. |
| const SCOPE_LOG = 'log'; | ||
| const SCOPE_SONET_GROUP = 'sonet_group'; | ||
|
|
||
| public function __construct( |
There was a problem hiding this comment.
You can remove this constructor.
|
done |
| $parameters['scope'] = implode(' ', $this->scopes); | ||
|
|
||
| // Build the url | ||
| $url = clone $this->getAccessTokenEndpoint(); |
There was a problem hiding this comment.
You don't need to clone the object as getAccessTokenEndpoint() returns a new new object.
There was a problem hiding this comment.
After this last change, this looks good to go 👍
|
thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.