Add instagram friend lists scope

[sajjadrad]

No description provided.

[sajjadrad]

https://www.instagram.com/developer/authorization/

[elliotchance]

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

src/OAuth/OAuth2/Service/Instagram.php, line 24 [r1] (raw file):
Why did you pick SCOPE_FRIEND_LIST instead of SCOPE_FOLLOWER_LIST like the convention of the others?

---

Comments from the review on Reviewable.io

[sajjadrad]

@elliotchance because it's not just follower_list, it will get following lists too.

[elliotchance]

Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

src/OAuth/OAuth2/Service/Instagram.php, line 24 [r1] (raw file):
Please reply on the reviewable: https://reviewable.io/reviews/lusitanian/phpoauthlib/458

I'm referring to the naming convention not what the actual scope returns. The name of the constant should be indicative of the value it represents like all the other constants.

Following on from what you said it would be good to put that as a comment on the constant since that's not clear.

---

Comments from the review on Reviewable.io

[sajjadrad]

Const name changed.

[elliotchance]

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from the review on Reviewable.io

[elliotchance]

Thanks @sajjadrad! https://github.com/Lusitanian/PHPoAuthLib/releases/tag/v0.8.7

---

Review status: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

---

Comments from the review on Reviewable.io