Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maPCA in tedana does not currently z-score data before performing PCA #24

Closed
eurunuela opened this issue Jan 19, 2021 · 3 comments
Closed

Comments

@eurunuela
Copy link
Collaborator

As discussed in tedana #636, the maPCA in tedana currently does not normalize data before performing PCA.

@tsalo already added the normalize option when he restructured the toolbox to be sklearn compatible. However, as I mentioned in the PR, I think we should add an if statement that checks the data is already z-scored and normalizes the data when it isn't. I'd remove the normalize option and do the normalization by default.

@eurunuela eurunuela added bug Something isn't working and removed bug Something isn't working labels Jan 19, 2021
@eurunuela eurunuela changed the title maPCA does not currently z-score data before performing PCA maPCA in tedana does not currently z-score data before performing PCA Jan 19, 2021
@tsalo
Copy link
Member

tsalo commented Jan 19, 2021

Running z-scoring along the same axis twice shouldn't cause any problems, right? Can we just do it no matter what?

@eurunuela
Copy link
Collaborator Author

You're right, we could just do it anyway. In the end, it'd be (y - 0)/1 if the data was already z-scored.

@eurunuela
Copy link
Collaborator Author

This was closed by #636 in tedana

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants