Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptive mask is generated using whole acquisition matrix, instead of brain mask #1059

Closed
tsalo opened this issue Mar 14, 2024 · 1 comment · Fixed by #1060
Closed

Adaptive mask is generated using whole acquisition matrix, instead of brain mask #1059

tsalo opened this issue Mar 14, 2024 · 1 comment · Fixed by #1060
Labels
bug issues describing a bug or error found in the project

Comments

@tsalo
Copy link
Member

tsalo commented Mar 14, 2024

Summary

The adaptive mask identifies its exemplar voxel(s) from the 33rd percentile of the available data. Currently, the available data used include the whole acquisition matrix, but it should be limited just to the brain mask.

Additional Detail

Stems from #1057 (comment).

Next Steps

  1. Test out current and proposed adaptive masking approaches on a range of datasets to see what effect it has.
@tsalo tsalo added the bug issues describing a bug or error found in the project label Mar 14, 2024
@tsalo
Copy link
Member Author

tsalo commented Mar 15, 2024

Here are results of the two approaches on some five-echo data I had on hand.

Original

This is after applying the brain mask after calculating the adaptive mask. I can plot the adaptive mask without applying the brain mask if folks want. Just let me know.

image

Limited to mask

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug issues describing a bug or error found in the project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant